OCPBUGS-33006: baremetal: aarch64-related fixes by honza · Pull Request #8385 · openshift/installer

honza · 2024-05-09T20:31:31Z

Correct the logic that checks host capabilities and arch
Undefine the bootstrap domain with flags, notably nvram
Set graphics devices to nil on aarch64

openshift-ci-robot · 2024-05-09T20:31:38Z

@honza: This pull request references Jira Issue OCPBUGS-33006, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jadhaj

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Previously, we used the default empty value before updating it to the actual host arch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Previously, we used the default empty value before updating it to the actual host arch.

openshift-ci-robot · 2024-05-10T11:41:03Z

@honza: This pull request references Jira Issue OCPBUGS-33006, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jadhaj

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Correct the logic that checks host capabilities and arch

Undefine the bootstrap domain with flags, notably nvram

Set graphics devices to nil on aarch64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

honza · 2024-05-14T14:07:57Z

/retest-required

pkg/infrastructure/baremetal/bootstrap.go

dtantsur · 2024-05-14T14:49:09Z

/lgtm

dtantsur · 2024-05-14T14:57:01Z

/lgtm

sadasu · 2024-05-14T17:46:04Z

/label acknowledge-critical-fixes-only

andfasano · 2024-05-14T17:46:29Z

/approve

openshift-ci · 2024-05-14T17:49:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [andfasano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-05-14T18:50:43Z

@honza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-assisted	`3397d08`	link	false	`/test e2e-metal-assisted`
ci/prow/e2e-metal-single-node-live-iso	`3397d08`	link	false	`/test e2e-metal-single-node-live-iso`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

zaneb · 2024-05-14T22:50:28Z

pkg/infrastructure/baremetal/bootstrap.go

@@ -291,19 +293,25 @@ func getCapabilities(virConn *libvirt.Libvirt) (libvirtxml.Caps, error) {
 func createBootstrapDomain(virConn *libvirt.Libvirt, config baremetalConfig, pool libvirt.StoragePool, volume libvirt.StorageVol) error {
 	bootstrapDom := newDomain(fmt.Sprintf("%s-bootstrap", config.ClusterID))


We're so close to being able to pass the arch to newDomain() 😜

The idea is that newDomain() returns all of the /static/ parts of the structure and then you can customize it with runtime values. 😄

or maybe using the builder pattern :)

openshift-ci-robot · 2024-05-15T00:45:20Z

@honza: Jira Issue OCPBUGS-33006: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33006 has been moved to the MODIFIED state.

Details

In response to this:

Correct the logic that checks host capabilities and arch

Undefine the bootstrap domain with flags, notably nvram

Set graphics devices to nil on aarch64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 9, 2024

openshift-ci bot requested review from jadhaj, jhixson74 and sadasu May 9, 2024 20:31

baremetal: set domain arch

d0d5d28

Previously, we used the default empty value before updating it to the actual host arch.

honza force-pushed the libvirt-arch branch from 76d18a5 to c785a45 Compare May 10, 2024 11:38

honza changed the title ~~OCPBUGS-33006: baremetal: set domain arch~~ OCPBUGS-33006: baremetal: aarch64-related fixes May 10, 2024

honza force-pushed the libvirt-arch branch from c785a45 to acae2b7 Compare May 10, 2024 12:25

dtantsur reviewed May 14, 2024

View reviewed changes

pkg/infrastructure/baremetal/bootstrap.go Outdated Show resolved Hide resolved

openshift-ci bot assigned dtantsur May 14, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024

honza added 2 commits May 14, 2024 11:53

baremetal: undefine domain with flags

38f5991

baremetal: clear out graphics on aarch64

3397d08

honza force-pushed the libvirt-arch branch from acae2b7 to 3397d08 Compare May 14, 2024 14:53

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 14, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 14, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024

zaneb reviewed May 14, 2024

View reviewed changes

openshift-merge-bot bot merged commit 930d8e1 into openshift:master May 15, 2024

		@@ -291,19 +293,25 @@ func getCapabilities(virConn *libvirt.Libvirt) (libvirtxml.Caps, error) {
		func createBootstrapDomain(virConn *libvirt.Libvirt, config baremetalConfig, pool libvirt.StoragePool, volume libvirt.StorageVol) error {
		bootstrapDom := newDomain(fmt.Sprintf("%s-bootstrap", config.ClusterID))

Conversation

honza commented May 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented May 9, 2024

Uh oh!

openshift-ci-robot commented May 10, 2024

Uh oh!

honza commented May 14, 2024

Uh oh!

Uh oh!

dtantsur commented May 14, 2024

Uh oh!

dtantsur commented May 14, 2024

Uh oh!

sadasu commented May 14, 2024

Uh oh!

andfasano commented May 14, 2024

Uh oh!

openshift-ci bot commented May 14, 2024

Uh oh!

openshift-ci bot commented May 14, 2024

Uh oh!

zaneb May 14, 2024

Choose a reason for hiding this comment

Uh oh!

honza May 14, 2024

Choose a reason for hiding this comment

Uh oh!

aleskandro May 15, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented May 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

honza commented May 9, 2024 •

edited

Loading